lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Jun 2012 22:00:50 +0530 From: Srikar Dronamraju <srikar@...ux.vnet.ibm.com> To: Oleg Nesterov <oleg@...hat.com> Cc: Ananth N Mavinakayanahalli <ananth@...ibm.com>, linuxppc-dev@...ts.ozlabs.org, lkml <linux-kernel@...r.kernel.org>, Paul Mackerras <paulus@...ba.org>, benh@...nel.crashing.org, Anton Blanchard <anton@...ba.org>, Ingo Molnar <mingo@...e.hu>, peterz@...radead.org Subject: Re: [PATCH 1/2] uprobes: Pass probed vaddr to arch_uprobe_analyze_insn() * Oleg Nesterov <oleg@...hat.com> [2012-06-06 17:08:48]: > On 06/06, Ananth N Mavinakayanahalli wrote: > > > > From: Ananth N Mavinakayanahalli <ananth@...ibm.com> > > > > On RISC architectures like powerpc, instructions are fixed size. > > Instruction analysis on such platforms is just a matter of (insn % 4). > > Pass the vaddr at which the uprobe is to be inserted so that > > arch_uprobe_analyze_insn() can flag misaligned registration requests. > > And the next patch checks "vaddr & 0x03". > > But why do you need this new arg? arch_uprobe_analyze_insn() could > check "container_of(auprobe, struct uprobe, arch)->offset & 0x3" with > the same effect, no? vm_start/vm_pgoff are obviously page-aligned. > We cant use container_of because we moved the definition for struct uprobe to kernel/events/uprobe.c. This was possible before when struct uprobe definition was in include/uprobes.h -- Thanks and Regards Srikar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists