linux-kernel - Re: [PATCH] libfcoe: Fix section mismatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Jun 2012 21:58:40 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Robert Love <robert.w.love@...el.com>
Cc:	linux-scsi@...r.kernel.org, baryluk@....if.uj.edu.pl,
	linux-kernel@...r.kernel.org, JBottomley@...allels.com,
	devel@...n-fcoe.org, Mark Rustad <mark.d.rustad@...el.com>,
	yi.zou@...el.com
Subject: Re: [PATCH] libfcoe: Fix section mismatch

On Wed, Jun 06, 2012 at 11:59:48AM -0700, Robert Love wrote:
> From: Mark Rustad <mark.d.rustad@...el.com>
> 
> Recent changes to add fcoe_sysfs caused libfcoe_init to call fcoe_transport_exit
> in a module initialization routine. The change resulted in the below error. This
> patch removes the __exit keyword from the fcoe_transport_exit definition such
> that it may be called from an __init routine.
> 
> WARNING: drivers/scsi/fcoe/libfcoe.o(.init.text+0x21): Section mismatch in reference from the function init_module() to the function .exit.text:fcoe_transp
> exit()
> The function __init init_module() references
> a function __exit fcoe_transport_exit().
> This is often seen when error handling in the init function
> uses functionality in the exit path.
> The fix is often to remove the __exit annotation of
> fcoe_transport_exit() so it may be used outside an exit section.
> 
> Signed-off-by: Mark Rustad <mark.d.rustad@...el.com>
> Signed-off-by: Robert Love <robert.w.love@...el.com>

Looks good.

Acked-by: Sam Ravnborg <sam@...nborg.org>

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/