[<prev] [next>] [day] [month] [year] [list]
Date: Wed, 6 Jun 2012 16:07:15 -0400
From: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To: Borislav Petkov <bp@...64.org>
Cc: "H. Peter Anvin" <hpa@...or.com>, Jacob Shin <jacob.shin@....com>,
Andre Przywara <andre.przywara@....com>, jeremy@...p.org,
xen-devel@...ts.xensource.com, LKML <linux-kernel@...r.kernel.org>,
Jan Beulich <JBeulich@...e.com>,
Ingo Molnar <mingo@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Borislav Petkov <borislav.petkov@....com>,
Yinghai Lu <yinghai@...nel.org>
Subject: Re: [PATCH 2/4] x86, CPU: Fix show_msr MSR accessing function
On Fri, Jun 01, 2012 at 04:52:36PM +0200, Borislav Petkov wrote:
> From: Borislav Petkov <borislav.petkov@....com>
>
> There's no real reason why, when showing the MSRs on a CPU at boottime,
> we should be using the AMD-specific variant. Simply use the generic safe
> one which handles #GPs just fine.
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
>
> Cc: Yinghai Lu <yinghai@...nel.org>
> Signed-off-by: Borislav Petkov <borislav.petkov@....com>
> ---
> arch/x86/kernel/cpu/common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index 82f29e70d058..232fba2d54c9 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -947,7 +947,7 @@ static void __cpuinit __print_cpu_msr(void)
> index_max = msr_range_array[i].max;
>
> for (index = index_min; index < index_max; index++) {
> - if (rdmsrl_amd_safe(index, &val))
> + if (rdmsrl_safe(index, &val))
> continue;
> printk(KERN_INFO " MSR%08x: %016llx\n", index, val);
> }
> --
> 1.7.9.3.362.g71319
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists