[<prev] [next>] [day] [month] [year] [list]
Date: Wed, 6 Jun 2012 16:07:34 -0400
From: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To: Borislav Petkov <bp@...64.org>
Cc: "H. Peter Anvin" <hpa@...or.com>, Jacob Shin <jacob.shin@....com>,
Andre Przywara <andre.przywara@....com>, jeremy@...p.org,
xen-devel@...ts.xensource.com, LKML <linux-kernel@...r.kernel.org>,
Jan Beulich <JBeulich@...e.com>,
Ingo Molnar <mingo@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Andreas Herrmann <andreas.herrmann3@....com>,
stable@...r.kernel.org.#.3.4+,
Borislav Petkov <borislav.petkov@....com>
Subject: Re: [PATCH 3/4] x86, AMD: Fix crash as Xen Dom0 on AMD Trinity
systems
On Fri, Jun 01, 2012 at 04:52:37PM +0200, Borislav Petkov wrote:
> From: Andre Przywara <andre.przywara@....com>
>
> f7f286a910221 ("x86/amd: Re-enable CPU topology extensions in case BIOS
> has disabled it") wrongfully added code which used the AMD-specific
> {rd,wr}msr variants for no real reason.
>
> This caused boot panics on xen which wasn't initializing the
> {rd,wr}msr_safe_regs pv_ops members properly.
>
> This, in turn, caused a heated discussion leading to us reviewing all
> uses of the AMD-specific variants and removing them where unneeded
> (almost everywhere except an obscure K8 BIOS fix, see 6b0f43ddfa358).
>
> Finally, this patch switches to the standard {rd,wr}msr*_safe* variants
> which should've been used in the first place anyway and avoided unneeded
> excitation with xen.
>
> Signed-off-by: Andre Przywara <andre.przywara@....com>
> Cc: Andreas Herrmann <andreas.herrmann3@....com>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> Cc: stable@...r.kernel.org # 3.4+
> Link: <http://lkml.kernel.org/r/1338383402-3838-1-git-send-email-andre.przywara@amd.com>
> [Boris: correct and expand commit message]
> Signed-off-by: Borislav Petkov <borislav.petkov@....com>
> ---
> arch/x86/kernel/cpu/amd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
> index 146bb6218eec..80ccd99542e6 100644
> --- a/arch/x86/kernel/cpu/amd.c
> +++ b/arch/x86/kernel/cpu/amd.c
> @@ -586,9 +586,9 @@ static void __cpuinit init_amd(struct cpuinfo_x86 *c)
> !cpu_has(c, X86_FEATURE_TOPOEXT)) {
> u64 val;
>
> - if (!rdmsrl_amd_safe(0xc0011005, &val)) {
> + if (!rdmsrl_safe(0xc0011005, &val)) {
> val |= 1ULL << 54;
> - wrmsrl_amd_safe(0xc0011005, val);
> + checking_wrmsrl(0xc0011005, val);
> rdmsrl(0xc0011005, val);
> if (val & (1ULL << 54)) {
> set_cpu_cap(c, X86_FEATURE_TOPOEXT);
> --
> 1.7.9.3.362.g71319
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists