linux-kernel - Re: [E1000-devel] [next-net PATCH] drivers/net/ethernet/intel/e1000e: fix unregistered net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1339029671.10602.81.camel@jtkirshe-mobl>
Date:	Wed, 06 Jun 2012 17:41:11 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Ethan Zhao <ethan.kernel@...il.com>
Cc:	eric.dumazet@...il.com, linux.nics@...el.com,
	e1000-devel@...ts.sourceforge.net,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [E1000-devel] [next-net PATCH]
 drivers/net/ethernet/intel/e1000e: fix unregistered net_device ethX name
 output by e1000e

On Wed, 2012-06-06 at 22:57 +0800, Ethan Zhao wrote:
> commit ca3ccc6835943287b6f69e973c126a02bc4de409
> Author: ethan.zhao <ethan.kernel@...il.com>
> Date:   Wed Jun 6 07:32:11 2012 -0700
> 
>         modified:   drivers/net/ethernet/intel/e1000e/param.c
> 
>     While e1000e_check_options() is called, netdev is not registered,
> so the
>     e1000e driver will print out confused ethernet interface name
> (unregistered net_device) :
> 
>     e1000e 0000:04:00.0:(unregistered net_device): Interrupt
> Throttling Rate (ints/sec) set to dynamic conservative mode
> 
>     So change e_info() back to dev_printk() by simply redefine the
> e_info macro used by
>     e1000e_check_options() and e1000_validate_option
> 
>     after applied this patch, we got:
> 
>     e1000e 0000:04:00.0: Interrupt Throttling Rate (ints/sec) set to
> dynamic conservative mode
>     e1000e 0000:04:00.0: irq 95 for MSI/MSI-X 

NACK, I currently have a patch in my queue from Bruce Allan to resolve
this issue.  I should be pushing the patch upstream in a few days.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)