linux-kernel - Re: [PATCH] blk-exec-assign-endio-before-queue-dead-check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOS58YOf0m5WUcn3b2f_PGr=P+DH1-0EHBy_fHw3xmccHW+zRA@mail.gmail.com>
Date:	Thu, 7 Jun 2012 14:37:47 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Muthu Kumar <muthu.lkml@...il.com>
Cc:	Jens Axboe <axboe@...nel.dk>,
	James.Bottomley@...senpartnership.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blk-exec-assign-endio-before-queue-dead-check

Hello,

On Thu, Jun 7, 2012 at 2:35 PM, Muthu Kumar <muthu.lkml@...il.com> wrote:
>> Looks like the bug there is rq->rq_disk and rq->end_io assignments
>> happening after the queue_dead check.  Just move the two lines before
>> queue_head check?
>
> Thought about that. But the problem is, original rq->end_io is not
> saved before the new assignment. But exploring further, I guess its ok
> in this use case.

It's supposed to be overridden, so I don't think that matters.

> One more thing to consider is, the completion function is called from
> the same calling context here. As far as my check, it looks ok. Let me
> know if you think otherwise.

Not sure what you mean.

> Anyway, patch attached (as well as inline).
>
> Regards,
> Muthu
>
> -----------------------
> blk-exec.c: In blk_execute_rq_nowait(), assign rq->endio,rq_disk
> before queue dead check.

Needs way more description.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/