linux-kernel - Re: [RESEND PATCH] dma: imx-sdma: buf_tail should be initialize in prepare function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1339057203.1927.9.camel@vkoul-udesk3>
Date:	Thu, 07 Jun 2012 13:50:03 +0530
From:	Vinod Koul <vinod.koul@...ux.intel.com>
To:	Richard Zhao <richard.zhao@...escale.com>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	shawn.guo@...il.com, kernel@...gutronix.de,
	dan.j.williams@...el.com, linuxzsc@...il.com
Subject: Re: [RESEND PATCH] dma: imx-sdma: buf_tail should be initialize in
 prepare function

On Mon, 2012-06-04 at 09:17 +0800, Richard Zhao wrote:
> This fix audio underrun issue. When SNDRV_PCM_TRIGGER_STOP
> and SNDRV_PCM_TRIGGER_START, it calls prepare again. buf_tail
> should be reset to zero.
> So move buf_tail initialization into prepare function.
> 
> Signed-off-by: Richard Zhao <richard.zhao@...escale.com>
> Acked-by: Shawn Guo <shawn.guo@...aro.org>
> ---
>  drivers/dma/imx-sdma.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index fb4f499..1dc2a4a 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -815,8 +815,6 @@ static int sdma_request_channel(struct sdma_channel *sdmac)
>  
>  	init_completion(&sdmac->done);
>  
> -	sdmac->buf_tail = 0;
> -
>  	return 0;
>  out:
>  
> @@ -927,6 +925,8 @@ static struct dma_async_tx_descriptor *sdma_prep_slave_sg(
>  
>  	sdmac->flags = 0;
>  
> +	sdmac->buf_tail = 0;
> +
>  	dev_dbg(sdma->dev, "setting up %d entries for channel %d.\n",
>  			sg_len, channel);
>  
> @@ -1027,6 +1027,8 @@ static struct dma_async_tx_descriptor *sdma_prep_dma_cyclic(
>  
>  	sdmac->status = DMA_IN_PROGRESS;
>  
> +	sdmac->buf_tail = 0;
> +
>  	sdmac->flags |= IMX_DMA_SG_LOOP;
>  	sdmac->direction = direction;
>  	ret = sdma_load_context(sdmac);

Applied, Thanks
-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/