linux-kernel - Re: processes hung after sys_renameat, and 'missing' processes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFysx_AA7QvOcZSaJPYPdaGvg6p_6u3fmNtn23a71F7ouw@mail.gmail.com>
Date:	Wed, 6 Jun 2012 18:40:23 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Dave Jones <davej@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Miklos Szeredi <mszeredi@...e.cz>, Jan Kara <jack@...e.cz>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: processes hung after sys_renameat, and 'missing' processes

On Wed, Jun 6, 2012 at 6:19 PM, Dave Jones <davej@...hat.com> wrote:
>
> ok, I ended up with..
>
>        WARN_ON_ONCE(!mutex_is_locked(&target->d_parent->d_inode->i_mutex));
>
>        if (dentry->d_parent != NULL)
>                WARN_ON_ONCE(!mutex_is_locked(&dentry->d_inode->i_mutex));

It should just be something like

    WARN_ON_ONCE(!mutex_is_locked(&dentry->d_parent->d_inode->i_mutex));
    WARN_ON_ONCE(!mutex_is_locked(&target->d_parent->d_inode->i_mutex));

(And doing it as two separate ones rather than one that tests both is
probably a good idea, so that you see *which* one it is that triggers
if they do)

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/