linux-kernel - Re: [PATCH 1/9] Staging: ipack/bridges/tpci200: remove gotos in tpci200_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120607083901.GK4400@mwanda>
Date:	Thu, 7 Jun 2012 11:39:01 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Miguel Gómez <magomez@...lia.com>
Cc:	gregkh@...uxfoundation.org, siglesias@...lia.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/9] Staging: ipack/bridges/tpci200: remove gotos in
 tpci200_free_irq().

On Thu, Jun 07, 2012 at 10:24:50AM +0200, Miguel Gómez wrote:
> Handle error conditions with simple returns instead of usig gotos.
> 
> Signed-off-by: Miguel Gómez <magomez@...lia.com>

Nope.  It was still supposed to release the lock on success.

Keep the out_unlock label, and remove the out label.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/