linux-kernel - Re: [PATCH RFC] iommu/amd: Fix missing iommu_shutdown initialization in passthrough mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120607093235.GK757@amd.com>
Date:	Thu, 7 Jun 2012 11:32:35 +0200
From:	Joerg Roedel <joerg.roedel@....com>
To:	Shuah Khan <shuah.khan@...com>
CC:	<iommu@...ts.linux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC] iommu/amd: Fix missing iommu_shutdown initialization
 in passthrough mode

On Wed, Jun 06, 2012 at 10:50:06AM -0600, Shuah Khan wrote:
> Change AMD iommu driver to call disable iommus in pass-through mode. AMD
> iommu driver's amd_iommu_init() routine doesn't initialize iommu_shutdown
> in pass-through mode. As a result iommu disable via a call to disable_iommus()
> doesn't happen at shutdown. Enable and disable of iommus is inconsistent in
> pass-through mode. IOMMU is enabled, but not disabled. IOMMU disable is called
> from error legs in amd_iommu_init() in pass-through mode.
> 
> Requesting for comments as I don't have access to AMD system that supports
> IOMMU. I tested the change on AMD platforms with GART IOMMU which is not
> sufficient.
> 
> Signed-off-by: Shuah Khan <shuah.khan@...com>

The patch is fine. Thanks, applied to iommu/fixes.

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/