linux-kernel - Re: [PATCH 2/3] usb: storage: add support write cache quirk on usb hdd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4FD09D35.9020505@mvista.com>
Date:	Thu, 07 Jun 2012 16:23:17 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Namjae Jeon <linkinjeon@...il.com>
CC:	James.Bottomley@...senPartnership.com, gregkh@...uxfoundation.org,
	mdharm-usb@...-eyed-alien.net, linux-usb@...r.kernel.org,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Namjae Jeon <namjae.jeon@...sung.com>,
	Pankaj Kumar <pankaj.km@...sung.com>,
	Amit Sahrawat <a.sahrawat@...sung.com>
Subject: Re: [PATCH 2/3] usb: storage: add support write cache quirk on usb
 hdd

Hello.

On 06-06-2012 16:20, Namjae Jeon wrote:

> Add support

    You missed "for" here and in the subject.

> write cache quirk on usb hdd. scsi driver will be set to wce by detecting write cache quirk in quirk list when plugging usb hdd.

> Signed-off-by: Namjae Jeon<namjae.jeon@...sung.com>
> Signed-off-by: Pankaj Kumar<pankaj.km@...sung.com>
> Signed-off-by: Amit Sahrawat<a.sahrawat@...sung.com>
> ---
>   drivers/usb/storage/scsiglue.c |    6 ++++++
>   drivers/usb/storage/usb.c      |    5 ++++-
>   include/linux/usb/quirks.h     |    3 +++
>   include/linux/usb_usual.h      |    4 +++-
>   4 files changed, 16 insertions(+), 2 deletions(-)

> diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c
> index a324a5d..f7d0ea5 100644
> --- a/drivers/usb/storage/scsiglue.c
> +++ b/drivers/usb/storage/scsiglue.c
[...]
> @@ -230,6 +231,11 @@ static int slave_configure(struct scsi_device *sdev)
>   					US_FL_SCM_MULT_TARG))&&
>   				us->protocol == USB_PR_BULK)
>   			us->use_last_sector_hacks = 1;
> +
> +		/* Check for the cache quirk present or not */
> +		if (us->pusb_dev->quirks & USB_QUIRK_WRITE_CACHE ||
> +				us->fflags & US_FL_WRITE_CACHE)
> +				sdev->wce_quirk = 1;

    You overindented the last statement, so that it looks a bit like a 
continuation of previous *if*.

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/