linux-kernel - Re: processes hung after sys_renameat, and 'missing' processes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120607020846.GD17566@redhat.com>
Date:	Wed, 6 Jun 2012 22:08:47 -0400
From:	Dave Jones <davej@...hat.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Miklos Szeredi <mszeredi@...e.cz>, Jan Kara <jack@...e.cz>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: processes hung after sys_renameat, and 'missing' processes

On Thu, Jun 07, 2012 at 02:54:10AM +0100, Al Viro wrote:

 > > Do you even need the "dentry->d_parent != dentry" test? When do we
 > > even rename root dentries?
 > 
 > Root of the filesystem - never; root of disconnected subtree - sure,
 > that's how they become connected to the tree.  See d_materialize_unique(),
 > for example...
 > 
 > BTW, I really need more coffee - those checks belong in __d_move(),
 > not d_move(); aforementioned d_materialize_unique() doesn't use d_move(),
 > it calls __d_move() directly.  Sorry.

np, I'll restart the build/test.

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/