linux-kernel - Re: [PATCH] Use test_and_clear_bit() instead atomic_dec_and_test() for stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1339073661.7559.1.camel@gandalf.stny.rr.com>
Date:	Thu, 07 Jun 2012 08:54:21 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Use test_and_clear_bit() instead atomic_dec_and_test()
 for stop_machine

On Wed, 2012-05-23 at 13:19 +0900, OGAWA Hirofumi wrote:
> OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> writes:
> 
> >> The down side to this is that it adds 4 more bytes on a 64bit
> >> machine. (sizeof(unsigned log) == 8 and sizeof(atomic_t) == 4)
> 
> Another patch without additional 4bytes. This simply change
> atomic_dec_and_test() to atomic_xchg().
> 

If nobody picked this up, you might want to resend it with my acked-by.
(The second patch, not the first). As patches added to replies are
usually ignored.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/