linux-kernel - Re: [PATCH 4/7] fs/direct-io.c: adjust suspicious bit operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49bokvb3o1.fsf@segfault.boston.devel.redhat.com>
Date:	Thu, 07 Jun 2012 10:24:46 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	Alexander Viro <viro@...iv.linux.org.uk>,
	kernel-janitors@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, joe@...ches.com,
	Julia Lawall <julia@...u.dk>
Subject: Re: [PATCH 4/7] fs/direct-io.c: adjust suspicious bit operation

Julia Lawall <Julia.Lawall@...6.fr> writes:

> From: Julia Lawall <Julia.Lawall@...6.fr>
>
> READ is 0, so the result of the bit-and operation is 0.  Rewrite with == as
> done elsewhere in the same file.
>
> This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Interesting catch, that one.  Yeah, we don't expect any readahead I/O to
be done via O_DIRECT.  The test for rw == READ all over that file seems
fine to me, given that.

Reviewed-by: Jeff Moyer <jmoyer@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/