linux-kernel - Re: NFS regression in v3.5-rc1: mount.nfs yells about incorrect mount option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120607154307.GQ12795@8bytes.org>
Date:	Thu, 7 Jun 2012 17:43:07 +0200
From:	Joerg Roedel <joro@...tes.org>
To:	Bryan Schumaker <bjschuma@...app.com>
Cc:	Trond Myklebust <Trond.Myklebust@...app.com>,
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: NFS regression in v3.5-rc1: mount.nfs yells about incorrect
 mount option

On Thu, Jun 07, 2012 at 11:17:39AM -0400, Bryan Schumaker wrote:
> On 06/07/2012 11:12 AM, Bryan Schumaker wrote:
> commit cdf66442fab82916fe38f928b4f91815195a294c
> Author: Bryan Schumaker <bjschuma@...app.com>
> Date:   Tue Jun 5 14:59:54 2012 -0400
> 
>     NFS4: Set parsed mount data version to 4
>     
>     This patch only affects mounting through "-t nfs4" since it doesn't set
>     up an nfs version to use in the mount data.  The nfs client was trying
>     to mount using NFS v0, causing either a BUG() or a protocol not
>     supported message.
>     
>     Signed-off-by: Bryan Schumaker <bjschuma@...app.com>
>     Signed-off-by: Trond Myklebust <Trond.Myklebust@...app.com>
> 
> diff --git a/fs/nfs/super.c b/fs/nfs/super.c
> index ff656c0..bdd6731 100644
> --- a/fs/nfs/super.c
> +++ b/fs/nfs/super.c
> @@ -2637,6 +2637,8 @@ static int nfs4_validate_mount_data(void *options,
>  	if (data == NULL)
>  		goto out_no_data;
>  
> +	args->version = 4;
> +
>  	switch (data->version) {
>  	case 1:
>  		if (data->host_addrlen > sizeof(args->nfs_server.address))

No, this doesn't fix it for me. Same behavior as with plain v3.5-rc1.


	Joerg


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/