linux-kernel - RE: [PATCH 1/2] block: Move general unplug callback function from md/raid to blk-core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5723ED3022C1484092D8E8139108116905581F3D9A@MX18A.corp.emc.com>
Date:	Thu, 7 Jun 2012 13:06:42 -0400
From:	<Tao.Guo@....com>
To:	<shli@...nel.org>
CC:	<glorioustao@...il.com>, <linux-kernel@...r.kernel.org>,
	<neilb@...e.de>, <axboe@...nel.dk>, <stable@...r.kernel.org>,
	<akpm@...ux-foundation.org>
Subject: RE: [PATCH 1/2] block: Move general unplug callback function from
 md/raid to blk-core

Well, I think I will take your suggestions. I am sending another version
of the patch.

Thanks,
-Tao

> -----Original Message-----
> From: shlikernel@...il.com [mailto:shlikernel@...il.com] On Behalf Of
> Shaohua Li
> Sent: Wednesday, June 06, 2012 10:07 AM
> To: Guo, Tao
> Cc: glorioustao@...il.com; linux-kernel@...r.kernel.org; neilb@...e.de;
> axboe@...nel.dk; stable@...r.kernel.org; akpm@...ux-foundation.org
> Subject: Re: [PATCH 1/2] block: Move general unplug callback function
> from md/raid to blk-core
> 
> 2012/6/5  <Tao.Guo@....com>:
> > If you ever tried to implement unplug function in umem, you would
> find the code was almost identical as in dm/raid driver.
> > For other components which also need such unplug mechanism, it will
> much more convenient to have such facilities.
> It's just several lines of code and your usage actually doesn't need
> the counter.
> It's unclear to me your usage requires to move the callback to list
> head.
> 
> > PS: What's your specific concern about blk_plug_cb handles each
> request_queue?
> the blk_plug_cb stores request_queue, which is incorrect to me. Why
> can't
> one plug cb unplug two or more request_queues?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/