linux-kernel - Re: linux-next: Tree for Jun 7 (staging/ccg #2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jun 2012 16:59:13 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Randy Dunlap <rdunlap@...otime.net>
cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	<linux-next@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>,
	<devel@...verdev.osuosl.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Mike Lockwood <lockwood@...roid.com>,
	Andrzej Pietrasiewicz <andrzej.p@...sung.com>
Subject: Re: linux-next: Tree for Jun 7 (staging/ccg #2)

On Thu, 7 Jun 2012, Randy Dunlap wrote:

> on x86_64:
> 
>   CC [M]  drivers/staging/ccg/ccg.o
> In file included from drivers/staging/ccg/../../usb/gadget/f_mass_storage.c:311:0,
>                  from drivers/staging/ccg/ccg.c:52:
> drivers/staging/ccg/../../usb/gadget/storage_common.c: In function 'fsg_lun_open':
> drivers/staging/ccg/../../usb/gadget/storage_common.c:686:3: error: implicit declaration of function 'bdev_logical_block_size'
> drivers/staging/ccg/../../usb/gadget/storage_common.c:687:3: error: implicit declaration of function 'blksize_bits'
> In file included from drivers/staging/ccg/ccg.c:52:0:
> drivers/staging/ccg/../../usb/gadget/f_mass_storage.c: In function 'fsg_main_thread':
> drivers/staging/ccg/../../usb/gadget/f_mass_storage.c:2624:2: error: implicit declaration of function 'set_fs'
> drivers/staging/ccg/../../usb/gadget/f_mass_storage.c:2624:2: error: implicit declaration of function 'get_ds'

The problems above are caused by the fact that 
drivers/staging/ccg/Kconfig does not make USB_G_CGG dependent on BLOCK.

> In file included from drivers/staging/ccg/ccg.c:59:0:
> drivers/staging/ccg/../../usb/gadget/f_fs.c: At top level:
> drivers/staging/ccg/../../usb/gadget/f_fs.c:40:0: warning: "pr_vdebug" redefined
> drivers/staging/ccg/../../usb/gadget/u_serial.c:138:0: note: this is the location of the previous definition

This could be fixed by adding a #ifndef guard to f_fs.c and u_serial.c.  
It's a little awkward to combine independent source files this way.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/