linux-kernel - Re: [PATCH 1/3] scsi: set to WCE if usb cache quirk is present.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 8 Jun 2012 08:07:27 +0900
From:	Namjae Jeon <linkinjeon@...il.com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	James.Bottomley@...senpartnership.com, gregkh@...uxfoundation.org,
	mdharm-usb@...-eyed-alien.net, linux-usb@...r.kernel.org,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Namjae Jeon <namjae.jeon@...sung.com>,
	Pankaj Kumar <pankaj.km@...sung.com>,
	Amit Sahrawat <a.sahrawat@...sung.com>
Subject: Re: [PATCH 1/3] scsi: set to WCE if usb cache quirk is present.

Hi. Sergei.

Good point. I will update.
Thanks for your review.

2012/6/7, Sergei Shtylyov <sshtylyov@...sta.com>:
> Hello.
>
> On 06-06-2012 16:20, Namjae Jeon wrote:
>
>> Make use of USB quirk method to identify such HDD while reading the cache
>> status in sd_probe(). If cache quirk is present for the HDD, lets assume
>> that cache is enabled and make WCE bit equal to 1.
>
>> Signed-off-by: Namjae Jeon<namjae.jeon@...sung.com>
>> Signed-off-by: Pankaj Kumar<pankaj.km@...sung.com>
>> Signed-off-by: Amit Sahrawat<a.sahrawat@...sung.com>
>> ---
>>   drivers/scsi/sd.c          |    9 +++++++--
>>   include/scsi/scsi_device.h |    1 +
>>   2 files changed, 8 insertions(+), 2 deletions(-)
>
>> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
>> index 6f0a4c6..33faf6d 100644
>> --- a/drivers/scsi/sd.c
>> +++ b/drivers/scsi/sd.c
>> @@ -2259,8 +2259,13 @@ bad_sense:
>>   		sd_printk(KERN_ERR, sdkp, "Asking for cache data failed\n");
>>
>>   defaults:
>> -	sd_printk(KERN_ERR, sdkp, "Assuming drive cache: write through\n");
>> -	sdkp->WCE = 0;
>> +	if (sdp->wce_quirk) {
>> +		sdkp->WCE = 1;
>> +		sd_printk(KERN_NOTICE, sdkp, "Assuming drive cache write back\n");
>
>     You forgot colon after "cache".
>
>> +	} else {
>> +		sd_printk(KERN_ERR, sdkp, "Assuming drive cache: write through\n");
>> +		sdkp->WCE = 0;
>
>     It makes sense to do assignments and printk() in the same order in both
>
> branches.
>
>> +	}
>>   	sdkp->RCD = 0;
>>   	sdkp->DPOFUA = 0;
>>   }
>
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/