linux-kernel - Re: [PATCH 2/3] staging: zram: conventions, _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FD1ABA6.6030103@vflare.org>
Date:	Fri, 08 Jun 2012 00:37:10 -0700
From:	Nitin Gupta <ngupta@...are.org>
To:	Sam Hansen <solid.se7en@...il.com>
CC:	Sam Hansen <sam@...bo-inc.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jerome Marchand <jmarchan@...hat.com>,
	Seth Jennings <sjenning@...ux.vnet.ibm.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] staging: zram: conventions, __aligned() attribute

On 06/07/2012 01:20 PM, Sam Hansen wrote:

> Using the __aligned() attribute in favor of __attribute__((aligned(size)))
> 
> Signed-off-by: Sam Hansen <solid.se7en@...il.com>
> ---
>  drivers/staging/zram/zram_drv.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/zram/zram_drv.h b/drivers/staging/zram/zram_drv.h
> index fbe8ac9..cda89ec 100644
> --- a/drivers/staging/zram/zram_drv.h
> +++ b/drivers/staging/zram/zram_drv.h
> @@ -85,7 +85,7 @@ struct table {
>  	u16 size;	/* object size (excluding header) */
>  	u8 count;	/* object ref count (not yet used) */
>  	u8 flags;
> -} __attribute__((aligned(4)));
> +} __aligned(4);
>  
>  struct zram_stats {
>  	u64 compr_size;		/* compressed size of pages stored */


I plan to get rid of this table soon (as part of zsmalloc compaction
work). So, we can skip any changes to this part of the code.

Thanks,
Nitin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/