linux-kernel - Re: [PATCH] delete seven tty headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120608101935.7b07b13d@pyramind.ukuu.org.uk>
Date:	Fri, 8 Jun 2012 10:19:35 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Arnd Bergmann <arnd@...db.de>, Jiri Slaby <jslaby@...e.cz>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] delete seven tty headers

On Fri, 08 Jun 2012 10:56:48 +0200
Paul Bolle <pebolle@...cali.nl> wrote:

> Commit 51c9d654c2def97827395a7fbfd0c6f865c26544 ("Staging: delete tty
> drivers") left seven headers unused: nothing in the tree includes them
> anymore. Two of those headers were still exported, but since nothing in
> the kernel actually uses the things those two headers provide, that
> seems pointless. Delete these seven tty headers too.
> Signed-off-by: Paul Bolle <pebolle@...cali.nl>

Acked-by: Alan Cox <alan@...ux.intel.com>

> 1) cdk.h, comstats.h, istallion.h, and stallion.h are still referenced
> in Documentation/ioctl/ioctl-number.txt and
> Documentation/magic-number.txt. Should those references be deleted too?

Probably - but the fact the ioctl numbers were used needs to remain to
avoid any bad reuses

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/