linux-kernel - Re: a whole bunch of crashes since todays -mm merge.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120607180515.4afffc89.akpm@linux-foundation.org>
Date:	Thu, 7 Jun 2012 18:05:15 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Dave Jones <davej@...hat.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-mm@...ck.org, Konstantin Khlebnikov <khlebnikov@...nvz.org>,
	Oleg Nesterov <oleg@...hat.com>
Subject: Re: a whole bunch of crashes since todays -mm merge.

On Thu, 7 Jun 2012 17:52:52 -0700 Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Thu, Jun 7, 2012 at 5:24 PM, Dave Jones <davej@...hat.com> wrote:
> > I just started seeing crashes while doing simple things, like logging on a console..
> 
> I'm looking at it right now, and the sync_mm_rss() patch is pure
> garbage. In many ways.
> 
> You can't do sync_mm_rss() from mmdrop(), because there's no reason to
> believe that the task that does mmdrop() does it on its own active_mm.
> And even if you *could* do it there, it's still horribly wrong,
> because it does it at the end *after* it already freed the mm!
> 
> Does it go away if you revert that (commit 40af1bbdca47). I wish I
> hadn't merged it, or that I had noticed how horrible it was before I
> pushed out.
> 

It appears this is due to me fat-fingering conflict resolution last
week.  That hunk is supposed to be in mm_release(), not mmput().    

It's probably best to throw the patch away for now - we'll try again.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/