linux-kernel - Re: [PATCH 1/2] pinctrl/nomadik: add STn8815 ASIC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FD22ABA.6010607@wwwdotorg.org>
Date:	Fri, 08 Jun 2012 10:39:22 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Linus Walleij <linus.walleij@...aro.org>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] pinctrl/nomadik: add STn8815 ASIC support

On 06/08/2012 03:07 AM, Linus Walleij wrote:
> This adds support for the STN8815 ASIC for the Nomadik pin
> controller.

> diff --git a/drivers/pinctrl/pinctrl-nomadik.c b/drivers/pinctrl/pinctrl-nomadik.c

> @@ -1717,6 +1717,8 @@ static int __devinit nmk_pinctrl_probe(struct platform_device *pdev)
>  			of_match_device(nmk_pinctrl_match, &pdev->dev)->data;
>  
>  	/* Poke in other ASIC variants here */
> +	if (version == PINCTRL_NMK_STN8815)
> +		nmk_pinctrl_stn8815_init(&npct->soc);
>  	if (version == PINCTRL_NMK_DB8500)
>  		nmk_pinctrl_db8500_init(&npct->soc);

One comment that came up in other reviews is that we shouldn't have a
single driver that switches on the SoC type it's running on and then
dispatches to different ${soc}_init() functions, but rather should have
multiple separate drivers, where each probe calls some utility function
with the appropriate SoC parameterization structures/tables.

IIRC, it was SPEAr, and I appear to have already converted Tegra to that
scheme.

Should we do the same conversion for nomadik too?

Aside from that, the series looks fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/