linux-kernel - Re: [PATCH v2 02/10] mm: frontswap: trivial coding convention issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+1xoqdUpcXdPHaFgjJOdLC2rm=WoVktuNkV_82QR4QaPg=CnA@mail.gmail.com>
Date:	Fri, 8 Jun 2012 22:36:14 +0200
From:	Sasha Levin <levinsasha928@...il.com>
To:	Pekka Enberg <penberg@...nel.org>
Cc:	dan.magenheimer@...cle.com, konrad.wilk@...cle.com,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 02/10] mm: frontswap: trivial coding convention issues

On Fri, Jun 8, 2012 at 10:16 PM, Pekka Enberg <penberg@...nel.org> wrote:
> On Fri, Jun 8, 2012 at 10:15 PM, Sasha Levin <levinsasha928@...il.com> wrote:
>> Signed-off-by: Sasha Levin <levinsasha928@...il.com>
>> ---
>>  mm/frontswap.c |    5 +++--
>>  1 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/mm/frontswap.c b/mm/frontswap.c
>> index 557e8af4..b619d29 100644
>> --- a/mm/frontswap.c
>> +++ b/mm/frontswap.c
>> @@ -150,6 +150,7 @@ int __frontswap_store(struct page *page)
>>                inc_frontswap_failed_stores();
>>        } else
>>                inc_frontswap_failed_stores();
>> +       }
>
> This looks wrong. Did you compile it?

gah... yes, I've had an error in the merge resolution, but since that
code is completely changed in next couple of patches I didn't notice
it when building the final version. I really should build after each
merge failure...

Konrad, would it be ok if I send just a new version of this patch (if
everything else is fine)?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/