linux-kernel - Re: writeback: bad unlock balance detected in 3.5-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120608205031.GG21080@quack.suse.cz>
Date:	Fri, 8 Jun 2012 22:50:31 +0200
From:	Jan Kara <jack@...e.cz>
To:	Fengguang Wu <fengguang.wu@...el.com>
Cc:	Jan Kara <jack@...e.cz>, Theodore Ts'o <tytso@....edu>,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: writeback: bad unlock balance detected in 3.5-rc1

On Sat 09-06-12 00:45:35, Wu Fengguang wrote:
> On Fri, Jun 08, 2012 at 05:07:36PM +0200, Jan Kara wrote:
> > On Fri 08-06-12 10:36:13, Ted Tso wrote:
> > > 
> > > I can reproduce this fairly easily by using ext4 w/o a journal, running
> > > under KVM with 1024megs memory, with fsstress (xfstests #13):
> 
> Good catch, thanks!
> 
> >   Argh, I wonder how come I didn't hit this. Does attached patch fix the
> > problem?
> 
> > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
> > index 8d2fb8c..41a3ccf 100644
> > --- a/fs/fs-writeback.c
> > +++ b/fs/fs-writeback.c
> > @@ -664,6 +664,7 @@ static long writeback_sb_inodes(struct super_block *sb,
> >  			/* Wait for I_SYNC. This function drops i_lock... */
> >  			inode_sleep_on_writeback(inode);
> >  			/* Inode may be gone, start again */
> > +			spin_lock(&wb->list_lock);
> >  			continue;
> >  		}
> 
> That looks like the fix. So I pushed it to writeback-for-next.
> Thanks for the quick fixing!
  Attached is a version with proper sign-off and changelog. Just in case
you didn't create one yourself already.

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR

View attachment "0001-writeback-Fix-lock-imbalance-in-writeback_sb_inodes.patch" of type "text/x-patch" (907 bytes)