linux-kernel - Re: [ 64/82] ext4: dont trash state flags in EXT4_IOC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1339125708.21665.108.camel@deadeye.wl.decadent.org.uk>
Date:	Fri, 08 Jun 2012 04:21:48 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Ted Ts'o <tytso@....edu>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, Tao Ma <boyu.mt@...bao.com>,
	Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [ 64/82] ext4: dont trash state flags in EXT4_IOC_SETFLAGS

On Thu, 2012-06-07 at 23:11 -0400, Ted Ts'o wrote:
> On Fri, Jun 08, 2012 at 04:03:09AM +0100, Ben Hutchings wrote:
> > >  		ei->i_flags = flags;
> > [...]
> > 
> > Shouldn't this last assignment have been deleted?
> 
> Yes, I'm testing two patches to push to Linus.  One of them deletes
> the last assignment.
> 
> The testing cycle should be over by tomorrow morning; in the mean
> time, this commit is harmless in its current form (although it won't
> fix the problem it was intending to fix until we delete the last
> line).
[...]

It's not harmless because the user is no longer restricted to changing
EXT4_FL_USER_MODIFIABLE.

Ben.

-- 
Ben Hutchings
I haven't lost my mind; it's backed up on tape somewhere.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)