linux-kernel - Re: [PATCH] mm/page-writeback.c: fix comments error in page-writeback.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120609115413.GA15811@localhost>
Date:	Sat, 9 Jun 2012 19:54:13 +0800
From:	Fengguang Wu <fengguang.wu@...el.com>
To:	Wanpeng Li <liwp.linux@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Gavin Shan <shangw@...ux.vnet.ibm.com>,
	Wanpeng Li <liwp@...ux.vnet.ibm.com>
Subject: Re: [PATCH] mm/page-writeback.c: fix comments error in
 page-writeback.c

On Sat, Jun 09, 2012 at 07:45:33PM +0800, Wanpeng Li wrote:
> From: Wanpeng Li <liwp@...ux.vnet.ibm.com>
> 
> Signed-off-by: Wanpeng Li <liwp@...ux.vnet.ibm.com>
> ---
>  mm/page-writeback.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 93d8d2f..c833bf0 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -930,7 +930,7 @@ static void bdi_update_dirty_ratelimit(struct backing_dev_info *bdi,
>  	 */
>  
>  	/*
> -	 * dirty_ratelimit will follow balanced_dirty_ratelimit iff
> +	 * dirty_ratelimit will follow balanced_dirty_ratelimit if

That 'iff' means 'if and only if'.

>  	 * task_ratelimit is on the same side of dirty_ratelimit, too.
>  	 * For example, when
>  	 * - dirty_ratelimit > balanced_dirty_ratelimit
> @@ -941,7 +941,7 @@ static void bdi_update_dirty_ratelimit(struct backing_dev_info *bdi,
>  	 * feel and care are stable dirty rate and small position error.
>  	 *
>  	 * |task_ratelimit - dirty_ratelimit| is used to limit the step size
> -	 * and filter out the sigular points of balanced_dirty_ratelimit. Which
> +	 * and filter out the singular points of balanced_dirty_ratelimit. Which
>  	 * keeps jumping around randomly and can even leap far away at times
>  	 * due to the small 200ms estimation period of dirty_rate (we want to
>  	 * keep that period small to reduce time lags).

I'll fold the above chunk into the previous patch.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/