[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4FD39904.2010808@mvista.com>
Date: Sat, 09 Jun 2012 22:42:12 +0400
From: Sergei Shtylyov <sshtylyov@...sta.com>
To: Namjae Jeon <linkinjeon@...il.com>
CC: James.Bottomley@...senPartnership.com, gregkh@...uxfoundation.org,
mdharm-usb@...-eyed-alien.net, stern@...land.harvard.edu,
bvanassche@....org, linux-usb@...r.kernel.org,
linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
Namjae Jeon <namjae.jeon@...sung.com>,
Pankaj Kumar <pankaj.km@...sung.com>,
Amit Sahrawat <a.sahrawat@...sung.com>
Subject: Re: [PATCH v3 2/4] usb: storage: add support for write cache quirk
on usb hdd
Hello.
On 06/09/2012 09:41 PM, Namjae Jeon wrote:
> Add support for write cache quirk on usb hdd. scsi driver will be set to wce
> by detecting write cache quirk in quirk list when plugging usb hdd.
> Signed-off-by: Namjae Jeon<namjae.jeon@...sung.com>
> Signed-off-by: Pankaj Kumar<pankaj.km@...sung.com>
> Signed-off-by: Amit Sahrawat<a.sahrawat@...sung.com>
> ---
> drivers/usb/storage/scsiglue.c | 5 +++++
> drivers/usb/storage/usb.c | 5 ++++-
> include/linux/usb_usual.h | 4 +++-
> 3 files changed, 12 insertions(+), 2 deletions(-)
> diff --git a/drivers/usb/storage/scsiglue.c b/drivers/usb/storage/scsiglue.c
> index a324a5d..fe42547 100644
> --- a/drivers/usb/storage/scsiglue.c
> +++ b/drivers/usb/storage/scsiglue.c
[...]
> @@ -529,6 +529,9 @@ static void adjust_quirks(struct us_data *us)
> case 'o':
> f |= US_FL_CAPACITY_OK;
> break;
> + case 'p':
> + f |= US_FL_WRITE_CACHE;
> + break;
> case 'r':
> f |= US_FL_IGNORE_RESIDUE;
> break;
You probably should unite this chunk with the documentation update patch.
> diff --git a/include/linux/usb_usual.h b/include/linux/usb_usual.h
> index 17df360..96fc152 100644
> --- a/include/linux/usb_usual.h
> +++ b/include/linux/usb_usual.h
> @@ -64,7 +64,9 @@
> US_FLAG(NO_READ_CAPACITY_16, 0x00080000) \
> /* cannot handle READ_CAPACITY_16 */ \
> US_FLAG(INITIAL_READ10, 0x00100000) \
> - /* Initial READ(10) (and others) must be retried */
> + /* Initial READ(10) (and others) must be retried */ \
> + US_FLAG(WRITE_CACHE, 0x00200000) \
You've been already told to keep '\' at the same level with the above '\'
and you're continuing to ignore this.
> + /* Write Cache status is not available */
>
> #define US_FLAG(name, value) US_FL_##name = value ,
> enum { US_DO_ALL_FLAGS };
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists