linux-kernel - Re: [PATCH RFT] regulator: max77686: Fix the delay time for set_voltage_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 9 Jun 2012 09:50:18 +0530
From:	Yadwinder Singh Brar <yadi.brar01@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Chiwoong Byun <woong.byun@...sung.com>,
	Jonghwa Lee <jonghwa3.lee@...sung.com>,
	Myungjoo Ham <myungjoo.ham@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Yadwinder Singh Brar <yadi.brar@...sung.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH RFT] regulator: max77686: Fix the delay time for set_voltage_time_sel

On Fri, Jun 8, 2012 at 2:51 PM, Axel Lin <axel.lin@...il.com> wrote:
> rdev->desc->uV_step * abs(new_selector - old_selector) returns uV.
> The unit of ramp_rate is mV/us.
> Thus 1000 should be multiplied.
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/regulator/max77686.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c
> index b76a038..10bf65a 100644
> --- a/drivers/regulator/max77686.c
> +++ b/drivers/regulator/max77686.c
> @@ -78,7 +78,7 @@ static int max77686_set_dvs_voltage_time_sel(struct regulator_dev *rdev,
>
>        return DIV_ROUND_UP(rdev->desc->uV_step *
>                            abs(new_selector - old_selector),
> -                           ramp_rate[max77686->ramp_delay]);
> +                           ramp_rate[max77686->ramp_delay] * 1000);
>  }
>
>  static int max77686_set_voltage_time_sel(struct regulator_dev *rdev,
> @@ -86,7 +86,7 @@ static int max77686_set_voltage_time_sel(struct regulator_dev *rdev,
>  {
>        /* Unconditionally 100 mV/us */
>        return DIV_ROUND_UP(rdev->desc->uV_step *
> -                           abs(new_selector - old_selector), 100);
> +                           abs(new_selector - old_selector), 100 * 1000);
>  }
>
>  static struct regulator_ops max77686_ops = {
> --

Reviewed-by: Yadwinder Singh Brar <yadi.brar@...sung.com>

Thanks,
Yadwinder.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/