linux-kernel - Re: [PATCH] driver core: fix shutdown races with probe/remove(v1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACVXFVOh2ex7-p_qqPDN5XyTQFaAhEXczPdCqJfNihb0N9GBdw@mail.gmail.com>
Date:	Sun, 10 Jun 2012 22:06:23 +0800
From:	Ming Lei <ming.lei@...onical.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] driver core: fix shutdown races with probe/remove(v1)

On Fri, Jun 8, 2012 at 9:40 PM, Alan Stern <stern@...land.harvard.edu> wrote:
>
> Would you prefer to use device_trylock in a loop?  I guess this comes

Yes, looks trylock in loop is safer than locking simply, and another
advantage is that the buggy device or driver can be logged.

So will do the v2 using trylock.

> down to which you prefer: a hang during shutdown, or a crash.  :-)

Considered that the device or driver can be logged, either hang or
crash will be fixed later by someone, :-)

Thanks,
--
Ming Lei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/