linux-kernel - Re: [PATCH 4/7] remoteproc: Assign boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Jun 2012 17:56:28 +0300
From:	Ohad Ben-Cohen <ohad@...ery.com>
To:	sjur.brandeland@...ricsson.com
Cc:	Loic PALLARDY <loic.pallardy@...ricsson.com>,
	Ludovic BARRE <ludovic.barre@...ricsson.com>,
	linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Sjur Brændeland <sjurbren@...il.com>
Subject: Re: [PATCH 4/7] remoteproc: Assign boot_addr in a separate function

On Wed, Jun 6, 2012 at 4:38 PM,  <sjur.brandeland@...ricsson.com> wrote:
> +/**
> + * rproc_set_boot_addr() - Set rproc's boot address.
> + * @rproc: remote processor which needs boot address set.
> + * @fw: the  the ELF firmware image

typo: s/the the/the/

> -       rproc->bootaddr = ehdr->e_entry;
> +       rproc_set_boot_addr(rproc, fw);

We might want to do this a little bit differently, something like:

rproc->bootaddr = rproc_get_boot_addr(rproc, fw);

This way the binary-format-specific handler really only retrieves the
boot address, without manipulating the framework's rproc structure.

If such handler doesn't exist, a default zero can be returned.

Thanks,
Ohad.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/