linux-kernel - blackfin: how is the I-pipe code supposed to be built?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1339365045.30984.78.camel@x61.thuisdomein>
Date:	Sun, 10 Jun 2012 23:50:45 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Mike Frysinger <vapier@...too.org>
Cc:	uclinux-dist-devel@...ckfin.uclinux.org,
	linux-kernel@...r.kernel.org
Subject: blackfin: how is the I-pipe code supposed to be built?

0) While working my way through the stack of apparently unused headers I
also looked at arch/blackfin/include/asm/ipipe_base.h, as nothing seems
to include that header. The last include of that file got removed in
commit 1353d050facf5efd8dc05ba6c4d7852fcb423b15 ("Blackfin/ipipe:
restore pipeline bits in irqflags"). So that header is unused since
v2.6.39.

1) Before submitting the (possibly trivial) patch to remove that header
I did some further research, because I wanted to be sure that removing
this header was a reasonable thing to do.

2) I learned that arch/blackfin/include/asm/ipipe_base.h got added to
the tree in commit 6a01f230339321292cf065551f8cf55361052461 ("Blackfin
arch: merge adeos blackfin part to arch/blackfin/"). That commit also
introduced the macro CONFIG_IPIPE. But it did not introduce the Kconfig
symbol IPIPE. (Neither did it add code that defines a macro
CONFIG_IPIPE.) So to me it looks like the I-pipe code got added to
v2.6.29 without proper Kbuild support.

3) And this is currently still the case. There seem to be no Kconfig
symbols IPIPE, IPIPE_DEBUG, IPIPE_DEBUG_CONTEXT, or IPIPE_TRACE_IRQSOFF.
(Neither seems there to be code that defines the macros CONFIG_IPIPE,
CONFIG_IPIPE_DEBUG, CONFIG_IPIPE_DEBUG_CONTEXT, or
CONFIG_IPIPE_TRACE_IRQSOFF.)

4) Whether or not arch/blackfin/include/asm/ipipe_base.h should be
removed isn't very interesting. What is more interesting is how the
blackfin I-pipe code is supposed to be built. How can this code be built
from what currently is in mainline?

Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/