linux-kernel - thinkpad_acpi: Saving bluetooth state to NVRAM problem and fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Jun 2012 13:18:41 +0400
From:	Vsevolod Kozlov <zaba@...t.net>
To:	linux-kernel@...r.kernel.org
Subject: thinkpad_acpi: Saving bluetooth state to NVRAM problem and fix

Hello,

thinkpad_acpi normally fails to save Bluetooth state to NVRAM on my system
(ThinkPad X120e).  However, a small change in the code fixes the functionality:

--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -3999,7 +3999,7 @@ static const struct tpacpi_rfk_ops bluetooth_tprfk_ops = {
 static void bluetooth_shutdown(void)
 {
 	/* Order firmware to save current state to NVRAM */
-	if (!acpi_evalf(NULL, NULL, "\\BLTH", "vd",
+	if (!acpi_evalf(NULL, NULL, "\\_SB.BLTH", "vd",
 			TP_ACPI_BLTH_SAVE_STATE))
 		pr_notice("failed to save bluetooth state to NVRAM\n");
 	else

I can't tell whether this breaks the functionality on other ThinkPad systems
because I don't have any, though.

Please CC me any responses, as I am not subscribed to the list.

Regards,

-- 
Zaba
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/