linux-kernel - Re: [PATCH] regulator: core: Return correct delay time in regulator_set_voltage_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKew6eV306Wu6v_AYgvBMeLce4ymZ-9pm=2wrZQ5KmV5XYcOeA@mail.gmail.com>
Date:	Mon, 11 Jun 2012 12:29:38 +0530
From:	Yadwinder Singh Brar <yadi.brar01@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Yadwinder Singh Brar <yadi.brar@...sung.com>,
	Liam Girdwood <lrg@...com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH] regulator: core: Return correct delay time in regulator_set_voltage_time_sel

On Mon, Jun 11, 2012 at 10:44 AM, Axel Lin <axel.lin@...il.com> wrote:
> rdev->desc->uV_step * abs(new_selector - old_selector) returns uV.
> The unit of ramp_delay is mV/us.
>
> Current code multiples 1000 at wrong place.
>

I am moving ramp_delay to constraints, so i have to modify this line again.
It will be corrected their.

Thanks,
Yadwinder.

> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/regulator/core.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index f4c056a..63507a5 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -2308,7 +2308,7 @@ int regulator_set_voltage_time_sel(struct regulator_dev *rdev,
>        if (rdev->desc->ramp_delay && rdev->desc->uV_step)
>                return DIV_ROUND_UP(rdev->desc->uV_step *
>                        abs(new_selector - old_selector),
> -                       rdev->desc->ramp_delay) * 1000;
> +                       rdev->desc->ramp_delay * 1000);
>        return 0;
>  }
>
> --
> 1.7.9.5
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/