linux-kernel - Re: [PATCH 1/2] perf, x86: Add basic Ivy Bridge support v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120611081634.GA31556@gmail.com>
Date:	Mon, 11 Jun 2012 10:16:35 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	eranian@...gle.com, linux-kernel@...r.kernel.org,
	Andi Kleen <ak@...ux.intel.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 1/2] perf, x86: Add basic Ivy Bridge support v2


* Andi Kleen <andi@...stfloor.org> wrote:

> +	char *name;
> +		name = "Ivy";
> +		name = "Sandy";
> -		pr_cont("SandyBridge events, ");
> +		pr_cont("%sBridge events, ", name);

Second round review feedback: you'll have to remove this ugly 
obfuscation, the kernel is already complex as-is. In performance 
insensitive code paths we want straight, obvious code without 
tricks.

Please resubmit the patches with this fixed.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/