linux-kernel - Re: [PATCH v2] clock: max77686: Add driver for Maxim 77686 32KHz crystal oscillator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120611091349.GE11439@opensource.wolfsonmicro.com>
Date:	Mon, 11 Jun 2012 17:13:50 +0800
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Jonghwa Lee <jonghwa3.lee@...sung.com>
Cc:	linux-kernel@...r.kernel.org,
	Mike Turquette <mturquette@...aro.org>,
	Arnd Bergmann <arnd@...db.de>,
	Hartley Sweeten <hsweeten@...ionengravers.com>,
	MyungJoo Ham <myungjoo.ham@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH v2] clock: max77686: Add driver for Maxim 77686 32KHz
 crystal oscillator

On Mon, Jun 11, 2012 at 04:35:31PM +0900, Jonghwa Lee wrote:

> +static int max77686_clk_enable(struct clk_hw *hw)

> +static void max77686_clk_disable(struct clk_hw *hw)

These need to be prepare() and unprepare() since these operations are
atomic.

> +{
> +	struct max77686_clk *max77686 = NULL;

The assignments here are redundant since you assign to the variable
immadiately.

> +	for ( i = 0; i < MAX77686_CLKS_NUM; i++) {

Coding style with ( i.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)