linux-kernel - Re: [PATCH] x86/apic: Eliminate cpu_mask_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120611105110.GB3383@dhcp-26-207.brq.redhat.com>
Date:	Mon, 11 Jun 2012 12:51:11 +0200
From:	Alexander Gordeev <agordeev@...hat.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Suresh Siddha <suresh.b.siddha@...el.com>,
	linux-kernel@...r.kernel.org, x86@...nel.org,
	Yinghai Lu <yinghai@...nel.org>
Subject: Re: [PATCH] x86/apic: Eliminate cpu_mask_to_apicid() operation

On Mon, Jun 11, 2012 at 10:22:49AM +0200, Ingo Molnar wrote:
> > @@ -2151,7 +2134,12 @@ int default_cpu_mask_to_apicid_and(const struct cpumask *cpumask,
> >  			break;
> >  	}
> >  
> > -	return __default_cpu_to_apicid(cpu, apicid);
> > +	if (likely((unsigned int)cpu < nr_cpu_ids)) {
> > +		*apicid = per_cpu(x86_cpu_to_apicid, cpu);
> > +		return 0;
> > +	} else {
> > +		return -EINVAL;
> > +	}
> 
> The type cast is rather ugly - why not change the cpu type to 
> unsigned int?

Tried to preserve in changelog as much original code as possible.
Suppose, it has been int to match cpumask_* functions.

> Also, the else block is superfluous, just make it a return 
> -EINVAL?

What about posting a separate patch, with the rest of apic drivers that have
the same branch/cast fixed, altogether?

> 
> Thanks,
> 
> 	Ingo

-- 
Regards,
Alexander Gordeev
agordeev@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/