| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-id: <2343140.762561339378822682.JavaMail.weblogic@epml04>
Date: Mon, 11 Jun 2012 01:40:23 +0000 (GMT)
From: MyungJoo Ham <myungjoo.ham@...sung.com>
To: Sachin Kamat <sachin.kamat@...aro.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc: "sameo@...ux.intel.com" <sameo@...ux.intel.com>,
"patches@...aro.org" <patches@...aro.org>
Subject: Re: [PATCH 1/1] mfd: max8997: Add missing static storage class
specifier
Sachin Kamat<sachin.kamat@...aro.org> Date : 2012-06-04 20:09 (GMT+09:00)
>
> Fixes the following sparse warnings:
> drivers/mfd/max8997.c:209:4: warning: symbol 'max8997_dumpaddr_pmic' was not declared. Should it be static?
> drivers/mfd/max8997.c:334:4: warning: symbol 'max8997_dumpaddr_muic' was not declared. Should it be static?
> drivers/mfd/max8997.c:344:4: warning: symbol 'max8997_dumpaddr_haptic' was not declared. Should it be static?
> drivers/mfd/max8997.c:426:25: warning: symbol 'max8997_pm' was not declared. Should it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
Acked-by: MyungJoo Ham <myungjoo.ham@...sung.com>
> ---
> drivers/mfd/max8997.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/mfd/max8997.c b/drivers/mfd/max8997.c
> index cb83a7a..454f499 100644
> --- a/drivers/mfd/max8997.c
> +++ b/drivers/mfd/max8997.c
> @@ -206,7 +206,7 @@ static const struct i2c_device_id max8997_i2c_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, max8998_i2c_id);
>
> -u8 max8997_dumpaddr_pmic[] = {
> +static u8 max8997_dumpaddr_pmic[] = {
> MAX8997_REG_INT1MSK,
> MAX8997_REG_INT2MSK,
> MAX8997_REG_INT3MSK,
> @@ -331,7 +331,7 @@ u8 max8997_dumpaddr_pmic[] = {
> MAX8997_REG_DVSOKTIMER5,
> };
>
> -u8 max8997_dumpaddr_muic[] = {
> +static u8 max8997_dumpaddr_muic[] = {
> MAX8997_MUIC_REG_INTMASK1,
> MAX8997_MUIC_REG_INTMASK2,
> MAX8997_MUIC_REG_INTMASK3,
> @@ -341,7 +341,7 @@ u8 max8997_dumpaddr_muic[] = {
> MAX8997_MUIC_REG_CONTROL3,
> };
>
> -u8 max8997_dumpaddr_haptic[] = {
> +static u8 max8997_dumpaddr_haptic[] = {
> MAX8997_HAPTIC_REG_CONF1,
> MAX8997_HAPTIC_REG_CONF2,
> MAX8997_HAPTIC_REG_DRVCONF,
> @@ -423,7 +423,7 @@ static int max8997_resume(struct device *dev)
> return max8997_irq_resume(max8997);
> }
>
> -const struct dev_pm_ops max8997_pm = {
> +static const struct dev_pm_ops max8997_pm = {
> .suspend = max8997_suspend,
> .resume = max8997_resume,
> .freeze = max8997_freeze,
> --
> 1.7.4.1
>
--
MyungJoo Ham (ΗΤΈνΑΦ), PHD
System S/W Lab, S/W Platform Team, Software Center
Samsung Electronics
Cell: +82-10-6714-2858
Powered by blists - more mailing lists