linux-kernel - Re: [PATCH] leds: Make LEDS_ASIC3 and LEDS_RENESAS_TPU depend on LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK5ve-Ksf1k_zZHBW64y4nRd3nr-ysxZ5jyKRtu0D1APuEms0A@mail.gmail.com>
Date:	Mon, 11 Jun 2012 22:37:38 +0800
From:	Bryan Wu <bryan.wu@...onical.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Magnus Damm <damm@...nsource.se>,
	Paul Parsons <lost.distance@...oo.com>,
	Richard Purdie <rpurdie@...ys.net>, linux-leds@...r.kernel.org
Subject: Re: [PATCH] leds: Make LEDS_ASIC3 and LEDS_RENESAS_TPU depend on LEDS_CLASS=y

On Sat, Jun 9, 2012 at 7:41 AM, Axel Lin <axel.lin@...il.com> wrote:
> Otherwise, I got below build error when CONFIG_LEDS_CLASS=m.
>
>  LD      init/built-in.o
> drivers/built-in.o: In function `asic3_led_probe':
> clkdev.c:(.devinit.text+0x4680): undefined reference to `led_classdev_register'
> drivers/built-in.o: In function `r_tpu_probe':
> clkdev.c:(.devinit.text+0x4838): undefined reference to `led_classdev_register'
> drivers/built-in.o: In function `asic3_led_remove':
> clkdev.c:(.devexit.text+0x564): undefined reference to `led_classdev_unregister'
> drivers/built-in.o: In function `r_tpu_remove':
> clkdev.c:(.devexit.text+0x5a0): undefined reference to `led_classdev_unregister'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Good, applied to my fixes-for-3.5 branch.

Thanks
-Bryan

> ---
>  drivers/leds/Kconfig |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 04cb8c8..12b2b55 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -379,7 +379,7 @@ config LEDS_NETXBIG
>
>  config LEDS_ASIC3
>        bool "LED support for the HTC ASIC3"
> -       depends on LEDS_CLASS
> +       depends on LEDS_CLASS=y
>        depends on MFD_ASIC3
>        default y
>        help
> @@ -390,7 +390,7 @@ config LEDS_ASIC3
>
>  config LEDS_RENESAS_TPU
>        bool "LED support for Renesas TPU"
> -       depends on LEDS_CLASS && HAVE_CLK && GENERIC_GPIO
> +       depends on LEDS_CLASS=y && HAVE_CLK && GENERIC_GPIO
>        help
>          This option enables build of the LED TPU platform driver,
>          suitable to drive any TPU channel on newer Renesas SoCs.
> --
> 1.7.9.5
>
>
>



-- 
Bryan Wu <bryan.wu@...onical.com>
Kernel Developer    +86.186-168-78255 Mobile
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/