linux-kernel - Re: [PATCH 1/2] edac: add support for Calxeda highbank memory controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Jun 2012 12:22:10 -0300
From:	Mauro Carvalho Chehab <mchehab@...hat.com>
To:	Rob Herring <robherring2@...il.com>
CC:	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH 1/2] edac: add support for Calxeda highbank memory controller

Em 06-06-2012 19:56, Rob Herring escreveu:
> Mauro,
> 
> On 06/06/2012 05:34 PM, Mauro Carvalho Chehab wrote:
>> Hi Rob,
>>
>> Em 06-06-2012 19:02, Rob Herring escreveu:
>>> From: Rob Herring <rob.herring@...xeda.com>
>>>
>>> Add support for memory controller on Calxeda Highbank platforms. Highbank
>>> platforms support a single 4GB mini-DIMM with 1-bit correction and 2-bit
>>> detection.
>>>
> 
> [snip]
> 
>>> +
>>> +	layers[0].type = EDAC_MC_LAYER_CHIP_SELECT;
>>> +	layers[0].size = 1;
>>> +	layers[0].is_virt_csrow = true;
>>> +	layers[1].type = EDAC_MC_LAYER_CHANNEL;
>>> +	layers[1].size = 1;
>>> +	layers[1].is_virt_csrow = false;
>>> +	mci = edac_mc_alloc(0, ARRAY_SIZE(layers), layers,
>>> +			    sizeof(struct hb_mc_drvdata));
>>
>> Hmm... I suspect that memories by DIMM chip select/channel at Calxeda,
>> as it is using just 1 cs/channel. It probably makes more sense to add new layer
>> type(s) to properly represent the way your memory controller addresses it, if
>> Calxeda doesn't work with DIMMs.
> 
> Not sure I follow. DIMMs are supported, but only a newer JEDEC form
> factor (DDR3 72-bit mini DIMM). The h/w pretty much fixed to a single
> 4GB DIMM. The controller is 1 72-bit channel.

OK. Then, the mapping is correct.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/