linux-kernel - Re: [PATCH] driver core: fix shutdown races with probe/remove(v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1206111202010.1607-100000@iolanthe.rowland.org>
Date:	Mon, 11 Jun 2012 12:02:31 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Ming Lei <ming.lei@...onical.com>
cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<stable@...r.kernel.org>
Subject: Re: [PATCH] driver core: fix shutdown races with probe/remove(v2)

On Mon, 11 Jun 2012, Ming Lei wrote:

> On Mon, Jun 11, 2012 at 10:16 PM, Alan Stern <stern@...land.harvard.edu> wrote:
> 
> >> +
> >> +             if (nonlocked)
> >> +                     dev_err(dev, "can't hold %slock for shutdown\n",
> >> +                                     nonlocked == 1 ? "" : "parent ");
> >
> > Even if the parent can't be locked, you should still try to lock the
> > device.
> 
> I have considered doing it, but which may consume another 1sec.
> 
> Also if the parent lock has been held, it is very possibly that the
> device can't be probed or removed at the same time, so just logged
> the crazy thing and go ahead.

Okay.  Then you can add my Acked-by.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/