linux-kernel - Re: [PATCH] net: socket: fixed coding style issues.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1339437203.2665.8.camel@bwh-desktop.uk.solarflarecom.com>
Date:	Mon, 11 Jun 2012 18:53:23 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Matthew Shaw <shaw500@...il.com>
CC:	<davem@...oft.net>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: socket: fixed coding style issues.

On Mon, 2012-06-11 at 14:17 +0100, Matthew Shaw wrote:
> Fixed an instance where brances are used but not needed, and some lines
> in the comments and code that exceed the 80 character limit.
> 
> Signed-off-by: Matthew Shaw <shaw500@...il.com>
> ---
>  net/socket.c |  137 ++++++++++++++++++++++++++++++++--------------------------
>  1 file changed, 75 insertions(+), 62 deletions(-)
> 
> diff --git a/net/socket.c b/net/socket.c
> index 6e0ccc0..2133040 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -8,48 +8,48 @@
>   *		Fred N. van Kempen, <waltje@...lt.NL.Mugnet.ORG>
>   *
>   * Fixes:
> - *		Anonymous	:	NOTSOCK/BADF cleanup. Error fix in
> - *					shutdown()
> - *		Alan Cox	:	verify_area() fixes
> - *		Alan Cox	:	Removed DDI
> - *		Jonathan Kamens	:	SOCK_DGRAM reconnect bug
[...]

I would question whether such lists of bug fixes are worth keeping at
all.  The names should probably be kept as credits, but the details are
ancient history now.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/