linux-kernel - Re: [PATCH] i2c-s3c2410: Fix pointer type passed to of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120611182925.GJ3887@pengutronix.de>
Date:	Mon, 11 Jun 2012 20:29:25 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Karol Lewandowski <k.lewandowsk@...sung.com>
Cc:	m.szyprowski@...sung.com, linux-kernel@...r.kernel.org,
	linux-i2c@...r.kernel.org,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH] i2c-s3c2410: Fix pointer type passed to of_match_node()

On Wed, May 30, 2012 at 11:43:05AM +0200, Karol Lewandowski wrote:
> This commit fixes warning introduced in 27452498a ("i2c-s3c2410: Rework
> device type handling"):
> 
>   drivers/i2c/busses/i2c-s3c2410.c: In function 's3c24xx_get_device_quirks':
>   drivers/i2c/busses/i2c-s3c2410.c:125: warning: passing argument 1 of 'of_match_node' from incompatible pointer type
>   include/linux/of.h:245: note: expected 'const struct of_device_id *' but argument is of type 'const struct of_device_id (*)[4]'
> 
> Signed-off-by: Karol Lewandowski <k.lewandowsk@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>

Ah, now I understand why my build-test didn't spot the warning.
What config can I use to test CONFIG_OF with s3c?

> ---
>  drivers/i2c/busses/i2c-s3c2410.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
> index fa0b134..286e596 100644
> --- a/drivers/i2c/busses/i2c-s3c2410.c
> +++ b/drivers/i2c/busses/i2c-s3c2410.c
> @@ -122,7 +122,7 @@ static inline unsigned int s3c24xx_get_device_quirks(struct platform_device *pde
>  {
>  	if (pdev->dev.of_node) {
>  		const struct of_device_id *match;
> -		match = of_match_node(&s3c24xx_i2c_match, pdev->dev.of_node);
> +		match = of_match_node(s3c24xx_i2c_match, pdev->dev.of_node);
>  		return (unsigned int)match->data;
>  	}
>  
> -- 
> 1.7.10
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)