linux-kernel - Re: [PATCH] mm: do not use page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120611002325.GA2384@kernel>
Date:	Mon, 11 Jun 2012 08:23:26 +0800
From:	Wanpeng Li <liwp.linux@...il.com>
To:	Minchan Kim <minchan@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Minchan Kim <minchan@...nel.org>,
	Andrea Arcangeli <aarcange@...hat.com>,
	MelGorman <mgorman@...e.de>, Michal Hocko <mhocko@...e.cz>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: [PATCH] mm: do not use page_count without a page pin

On Mon, Jun 11, 2012 at 09:17:51AM +0900, Minchan Kim wrote:
>d179e84ba fixed the problem[1] in vmscan.c but same problem is here.
>Let's fix it.
>
>[1] http://comments.gmane.org/gmane.linux.kernel.mm/65844
>
>I copy and paste d179e84ba's contents for description.
>
>"It is unsafe to run page_count during the physical pfn scan because
>compound_head could trip on a dangling pointer when reading
>page->first_page if the compound page is being freed by another CPU."
>
>Cc: Andrea Arcangeli <aarcange@...hat.com>
>Cc: Mel Gorman <mgorman@...e.de>
>Cc: Michal Hocko <mhocko@...e.cz>
>Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
>Signed-off-by: Minchan Kim <minchan@...nel.org>
>---
> mm/page_alloc.c |    6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>index 266f267..019c4fe 100644
>--- a/mm/page_alloc.c
>+++ b/mm/page_alloc.c
>@@ -5496,7 +5496,11 @@ __count_immobile_pages(struct zone *zone, struct page *page, int count)
> 			continue;
> 
> 		page = pfn_to_page(check);
>-		if (!page_count(page)) {
>+		/*
>+		 * We can't use page_count withou pin a page
                                        ^
										without
>+		 * because another CPU can free compound page.
>+		 */
>+		if (!atomic_read(&page->_count)) {
> 			if (PageBuddy(page))
> 				iter += (1 << page_order(page)) - 1;
> 			continue;
>-- 
>1.7.9.5
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@...ck.org.  For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/