linux-kernel - Re: [PATCH v2] watchdog: Quiet down the boot messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120611195414.GH32472@redhat.com>
Date:	Mon, 11 Jun 2012 15:54:14 -0400
From:	Don Zickus <dzickus@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, nzimmer@....com,
	joe@...ches.com
Subject: Re: [PATCH v2] watchdog: Quiet down the boot messages

On Fri, Jun 08, 2012 at 02:39:28PM -0700, Andrew Morton wrote:
> > After the change, it is simplified to:
> > 
> >     ..TIMER: vector=0x30 apic1=0 pin1=2 apic2=-1 pin2=-1
> >     CPU0: Intel(R) Core(TM)2 Quad CPU    Q9550  @ 2.83GHz stepping 0a
> >     Performance Events: PEBS fmt0+, Core2 events, Intel PMU driver.
> >     ... version:                2
> >     ... bit width:              40
> >     ... generic registers:      2
> >     ... value mask:             000000ffffffffff
> >     ... max period:             000000007fffffff
> >     ... fixed-purpose events:   3
> >     ... event mask:             0000000700000003
> >     NMI watchdog enabled, takes one hw-pmu counter.
> >     Booting Node   0, Processors  #1 #2 #3 Ok.
> >     Brought up 4 CPUs
> 
> What is the behaviour of this change at suspend/resume time?

Good question.  Aside from the brokeness that cpu0 doesn't seem to restart
after cpu suspend/resume (hence a previous patch in this space), the printks
disappear during resume.

Now with the cpu0 fix patch, the message will reappear and state that the
watchdog is enabled for all cpus.  But with just this patch, that message
will not show up during resume.

> 
> > +		if (cpu ==0 || cpu0_err)
> 
> Please use checkpatch.  It's free!

Heh.  Sorry about that.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/