linux-kernel - Re: [PATCH] mm: clean up __count_immobile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20120611144011.60fd76c8.akpm@linux-foundation.org>
Date:	Mon, 11 Jun 2012 14:40:11 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Minchan Kim <minchan@...nel.org>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Mel Gorman <mgorman@...e.de>, Michal Hocko <mhocko@...e.cz>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Subject: Re: [PATCH] mm: clean up __count_immobile_pages

On Mon, 11 Jun 2012 11:07:22 +0900
Minchan Kim <minchan@...nel.org> wrote:

> __count_immobile_pages naming is rather awkward.
> This patch clean up the function and add comment.

This conflicts with
mm-compaction-handle-incorrect-migrate_unmovable-type-pageblocks.patch
and its fixes.

> + * This function can race in PageLRU and MIGRATE_MOVABLE can have unmovable
> + * pages so that it might be not exact.

I don't understand this.  Functions race against other functions, not
against a page flag.  Can we have another attempt at this description
please?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/