linux-kernel - Re: [PATCH v3 3/3] usb: storage: update usb devices for write cache quirk in quirk list.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Jun 2012 07:47:41 +0900
From:	Namjae Jeon <linkinjeon@...il.com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	James.Bottomley@...senpartnership.com, gregkh@...uxfoundation.org,
	mdharm-usb@...-eyed-alien.net, stern@...land.harvard.edu,
	bvanassche@....org, linux-usb@...r.kernel.org,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Namjae Jeon <namjae.jeon@...sung.com>,
	Pankaj Kumar <pankaj.km@...sung.com>,
	Amit Sahrawat <a.sahrawat@...sung.com>
Subject: Re: [PATCH v3 3/3] usb: storage: update usb devices for write cache
 quirk in quirk list.

2012/6/12, Sergei Shtylyov <sshtylyov@...sta.com>:
> Hello.
>
> On 10-06-2012 4:45, Namjae Jeon wrote:
>
>>>> Update information of Seagate Portable HDD and WD My Passport HDD in
>>>> quirk list.
>
>>>> Signed-off-by: Namjae Jeon<namjae.jeon@...sung.com>
>>>> Signed-off-by: Pankaj Kumar<pankaj.km@...sung.com>
>>>> Signed-off-by: Amit Sahrawat<a.sahrawat@...sung.com>
>>>> ---
>>>>    drivers/usb/storage/unusual_devs.h |   24 ++++++++++++++++++++++++
>>>>    1 file changed, 24 insertions(+)
>
>>>> diff --git a/drivers/usb/storage/unusual_devs.h
>>>> b/drivers/usb/storage/unusual_devs.h
>>>> index 1719886..64f0369 100644
>>>> --- a/drivers/usb/storage/unusual_devs.h
>>>> +++ b/drivers/usb/storage/unusual_devs.h
>>>> @@ -1267,6 +1267,18 @@ UNUSUAL_DEV( 0x0af0, 0xd357, 0x0000, 0x0000,
>>>>    		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>>>>    		0 ),
>>>>
>>>> +/* Reported by Namjae Jeon<namjae.jeon@...sung.com>
>>>> + * Even though write cache is enabled by default,
>>>> + * SCSI driver assume that cache is not enabled
>>>> + * which in turn might lead loss of data
>>>                                 ^ to the
>
>>>> + * since data still will be in cache.
>>>> + * So this entry is needed for assuming that cache is enabled.
>>>> + */
>>>> +UNUSUAL_DEV(0x0bc2, 0x2300, 0x0000, 0x9999,
>>>> +		"Seagate",
>>>> +		"Portable HDD",
>>>> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
>>>> +
>>>>    /* Reported by Ben Efros<ben@...doctor.com>   */
>>>>    UNUSUAL_DEV( 0x0bc2, 0x3010, 0x0000, 0x0000,
>>>>    		"Seagate",
>>>> @@ -1468,6 +1480,18 @@ UNUSUAL_DEV(  0x1058, 0x0704, 0x0000, 0x9999,
>>>>    		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>>>>    		US_FL_SANE_SENSE),
>>>>
>>>> +/* Reported by Namjae Jeon<namjae.jeon@...sung.com>
>>>> + * Even though write cache is enabled by default,
>>>> + * SCSI driver assume that cache is not enabled
>>>> + * which in turn might lead loss of data
>>>                                 ^ to the
>> to the ? Sorry, I don't understand what you want to change.
>> like this ? "Even though write cache is enabled by default, SCSI
>> driver assume that cache is not enabled and it in turn might lead the
>> loss of data. "
>
>     Lead to the loss of data.
Okay, I changed it on the latest patch.
Thanks a lot.
>
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/