linux-kernel - Re: [PATCH v2 2/3][RESEND] backlight: ot200_bl: use devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF+7xW=UR4qXg9Pu4aMtHPYP6ATyvqwkW1wY=E2VvdmT6SAScQ@mail.gmail.com>
Date:	Tue, 12 Jun 2012 14:25:25 +0800
From:	Axel Lin <axel.lin@...il.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Richard Purdie <rpurdie@...ys.net>,
	Christian Gmeiner <christian.gmeiner@...il.com>
Subject: Re: [PATCH v2 2/3][RESEND] backlight: ot200_bl: use devm_ functions

>  error_mfgpt_alloc:
>        gpio_free(GPIO_DIMM);

You can also use devm_gpio_request, so you can remove gpio_free here
and remove the gpio_free in ot200_backlight_remove().

> @@ -141,7 +139,6 @@ error_mfgpt_alloc:
>  static int ot200_backlight_remove(struct platform_device *pdev)
>  {
>        struct backlight_device *bl = platform_get_drvdata(pdev);
> -       struct ot200_backlight_data *data = bl_get_data(bl);
>
>        backlight_device_unregister(bl);
>
> @@ -154,7 +151,6 @@ static int ot200_backlight_remove(struct platform_device *pdev)
>        cs5535_mfgpt_free_timer(pwm_timer);
>        gpio_free(GPIO_DIMM);
>
> -       kfree(data);
>        return 0;
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/