linux-kernel - Re: [PATCH] crypto: aes - make assembler implementation default for i386 and x86-64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120612082651.GA13419@gondor.apana.org.au>
Date:	Tue, 12 Jun 2012 16:26:51 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Jussi Kivilinna <jussi.kivilinna@...et.fi>
Cc:	linux-crypto@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: aes - make assembler implementation default
 for i386 and x86-64

On Sat, Jun 09, 2012 at 05:50:55PM +0300, Jussi Kivilinna wrote:
> AES is often built-in and therefore implementations other than aes-generic
> don't get autoloaded by module-aliases. This is solved for aes-ni by cpuid
> autoloading, but for x86-64/i586 assembler implementation cpuid matching
> does not make much sense (aes-generic built-in but overridden by x86-64/i586
> assembler implementation module). Instead change Kconfig so that assembler
> implementation is default on x86-64 and i386.
> 
> This patch also splits common parts exported to assembler implementations
> from aes-generic to new module aes-common.
> 
> Patch tested on x86-64, compile tested on i386 and arm.
> 
> Signed-off-by: Jussi Kivilinna <jussi.kivilinna@...et.fi>

I like the idea but I'm not sure about where we draw the line.
E.g., why not enable padlock, or for that matter every single
hardware implementation of AES?

This can get unwieldy very quickly.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/