linux-kernel - Re: [PATCH] trivial: treewide: remove extra semicolon added by module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zk89nznn.fsf@rustcorp.com.au>
Date:	Tue, 12 Jun 2012 09:56:36 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	Felipe Balbi <balbi@...com>, trivial@...nel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] trivial: treewide: remove extra semicolon added by module_init/exit

On Mon, 11 Jun 2012 14:20:28 -0700, Stephen Hemminger <shemminger@...tta.com> wrote:
> Given common kernel practice and the fact that only 16% of the uses of
> module_init/exit are without semicolon and that other kernel macros don't
> include semicolon.
> 
> I recommend going with the majority and common practice...
>   1. Fix the 636 places that use module_init()/exit without semicolon to include semicolon
>   2. Remove semicolon from module_init()/exit()

Um, yes.  He should do exactly what he did.

It's a wart, let's fix it.

Thanks,
Rusty.
PS. CC's chopped; somewhere in there is a bad address...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/