linux-kernel - Re: [PATCH] writeback: avoid race when update bandwidth

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120612112936.GA3026@kernel>
Date:	Tue, 12 Jun 2012 19:29:49 +0800
From:	Wanpeng Li <liwp.linux@...il.com>
To:	Fengguang Wu <fengguang.wu@...el.com>
Cc:	linux-kernel@...r.kernel.org,
	Gavin Shan <shangw@...ux.vnet.ibm.com>,
	Wanpeng Li <liwp.linux@...il.com>
Subject: Re: [PATCH] writeback: avoid race when update bandwidth

On Tue, Jun 12, 2012 at 07:21:29PM +0800, Fengguang Wu wrote:
>On Tue, Jun 12, 2012 at 06:26:43PM +0800, Wanpeng Li wrote:
>> From: Wanpeng Li <liwp@...ux.vnet.ibm.com>
>
>That email address is no longer in use?

No, :), you better use "Wanpeng Li <liwp@...ux.vnet.ibm.com>" to commit
my patch. Because next month this email address will be available again,
and this also can help my colleagues to add my patches count this year,
thanks a lot.
>
>> Since bdi->wb.list_lock is used to protect the b_* lists,
>> so the flushers who call wb_writeback to writeback pages will
>> stuck when bandwidth update policy holds this lock. In order
>> to avoid this race we can introduce a new bandwidth_lock who
>> is responsible for protecting bandwidth update policy.
>
>This looks good to me. wb.list_lock could be contended and it's better
>for bdi_update_bandwidth() to use a standalone and hardly contended
>lock.
>
>btw, with this change, the dirty_lock in global_update_bandwidth() can
>be eliminated.

Ok, I will resend the patch.

Regards,
Wanpeng Li
>
>> Signed-off-by: Wanpeng Li <liswp@...ux.vnet.ibm.com>
>> ---
>>  mm/page-writeback.c |    6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>> 
>> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
>> index c8945e0..b3b08fb 100644
>> --- a/mm/page-writeback.c
>> +++ b/mm/page-writeback.c
>> @@ -1032,12 +1032,14 @@ static void bdi_update_bandwidth(struct backing_dev_info *bdi,
>>  				 unsigned long bdi_dirty,
>>  				 unsigned long start_time)
>>  {
>> +	static DEFINE_SPINLOCK(bandwidth_lock);
>> +
>>  	if (time_is_after_eq_jiffies(bdi->bw_time_stamp + BANDWIDTH_INTERVAL))
>>  		return;
>> -	spin_lock(&bdi->wb.list_lock);
>> +	spin_lock(&bandwidth_lock);
>>  	__bdi_update_bandwidth(bdi, thresh, bg_thresh, dirty,
>>  			       bdi_thresh, bdi_dirty, start_time);
>> -	spin_unlock(&bdi->wb.list_lock);
>> +	spin_unlock(&bandwidth_lock);
>>  }
>>  
>>  /*
>> -- 
>> 1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/